Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OverlayFS now has COW #3989

Merged
merged 12 commits into from
Jun 15, 2023
Merged

OverlayFS now has COW #3989

merged 12 commits into from
Jun 15, 2023

Conversation

john-sharratt
Copy link
Contributor

No description provided.

theduke
theduke reviewed Jun 12, 2023
View reviewed changes
Copy link
Contributor

@theduke theduke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly looks good to me.

lib/virtual-fs/src/lib.rs Outdated Show resolved Hide resolved
@Michael-F-Bryan
Copy link
Contributor

As best I can tell, this is a summary of what this PR does:

  • The FileSystem::rename() method is now async
  • Introduces support for "whiteout files" - after a bit of googling (see here and here), this is an idea Docker (technically AUFS) uses for their unionfs where "deleting" a file from a read-only filesystem will actually create a new file prepended with .wh. that tells the unionfs to treat the file as deleted
  • Fixes the conditional_union so we merge a package's filesystem into the main filesystem when spawning (previously only worked when you used the "sandboxed" WasiFsRoot)

@Michael-F-Bryan Michael-F-Bryan added this to the v4.0 milestone Jun 13, 2023
@Michael-F-Bryan Michael-F-Bryan linked an issue Jun 13, 2023 that may be closed by this pull request
Showing unnecessary WARN when running a package #3948
Closed
@theduke theduke mentioned this pull request Jun 13, 2023
Closed
@john-sharratt john-sharratt changed the title OverlayFS now has COW and some limited unit tests OverlayFS now has COW Jun 15, 2023
@Michael-F-Bryan Michael-F-Bryan merged commit 10d17ef into master Jun 15, 2023
@Michael-F-Bryan Michael-F-Bryan deleted the fixes-for-overlay-fs branch June 15, 2023 06:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@theduke theduke theduke left review comments

@Michael-F-Bryan Michael-F-Bryan Michael-F-Bryan approved these changes

@ptitSeb ptitSeb Awaiting requested review from ptitSeb

@syrusakbary syrusakbary Awaiting requested review from syrusakbary

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v4.0
Development

Successfully merging this pull request may close these issues.

Showing unnecessary WARN when running a package
3 participants
@john-sharratt @Michael-F-Bryan @theduke