Display human-friendly progress when starting wasmer run
#3985
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 14, 2023
Michael-F-Bryan
force-pushed
the
wasmer-run-output
branch
from
79190f8 to
5cee446
Compare
Michael-F-Bryan
force-pushed
the
wasmer-run-output
branch
from
5cee446 to
f00edf6
Compare
ptitSeb
reviewed
Jun 19, 2023
ptitSeb
approved these changes
Jun 19, 2023
added 7 commits
June 20, 2023 16:18
Michael-F-Bryan
force-pushed
the
wasmer-run-output
branch
from
3f09d8d to
2def425
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #3981 by adding some spinners during certain parts of the startup process.
I've mostly done this by creating a wrapper
wasmer_wasix::Runtimeimplementation that will display progress bars during certain operations. Unfortunately, our current abstractions don't really expose the hooks we'd want for fine-grained progress updates like telling people how many bytes have been downloaded for a certain package, and some expensive operations (e.g. module compilation) aren't possible to hook into for reporting progress, but I guess it's better than nothing 🤷