Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix so that conditional_union works again #3976

Closed
wants to merge 2 commits into from
Closed

Fix so that conditional_union works again #3976

wants to merge 2 commits into from

Conversation

john-sharratt
Copy link
Contributor

No description provided.

Michael-F-Bryan
Michael-F-Bryan approved these changes Jun 9, 2023
View reviewed changes
Copy link
Contributor

@Michael-F-Bryan Michael-F-Bryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should work for what we need 👍

In the long term, we'll want to make that merge_filesystems() operation cheap, but that's not easily doable with the current WasiFsRoot design.

@Michael-F-Bryan
Copy link
Contributor

This was superseded by #1009.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Michael-F-Bryan Michael-F-Bryan Michael-F-Bryan approved these changes

@syrusakbary syrusakbary Awaiting requested review from syrusakbary

@theduke theduke Awaiting requested review from theduke

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@john-sharratt @Michael-F-Bryan