Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added the missing sock_accept for preview1 #3971

Merged
merged 4 commits into from
Jun 8, 2023
Merged

Added the missing sock_accept for preview1 #3971

merged 4 commits into from
Jun 8, 2023

Conversation

john-sharratt
Copy link
Contributor

No description provided.

@john-sharratt john-sharratt requested a review from syrusakbary June 8, 2023 07:20
@john-sharratt john-sharratt mentioned this pull request Jun 8, 2023
Closed
@john-sharratt john-sharratt requested review from theduke and ptitSeb June 8, 2023 07:21
theduke
theduke reviewed Jun 8, 2023
View reviewed changes
Copy link
Contributor

@theduke theduke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should also have a test for this to make sure a preview1 compiled .wasm works.

@theduke theduke enabled auto-merge (rebase) June 8, 2023 11:08
@theduke theduke merged commit 07fc1ed into master Jun 8, 2023
@theduke theduke deleted the fix-for-python-3-11 branch June 8, 2023 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ptitSeb ptitSeb ptitSeb approved these changes

@theduke theduke theduke approved these changes

@syrusakbary syrusakbary Awaiting requested review from syrusakbary

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@john-sharratt @theduke @ptitSeb