chore(cli): Remove redundant CLI feature flags #3955
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ptitSeb
approved these changes
Jun 5, 2023
theduke
force-pushed
the
issue-3954-remove-old-cli-feature-flags
branch
2 times, most recently
from
9386c8f to
795b948
Compare
The CLI previously had a bunch of feature flags, which were only left in for legacy support, but which do not change behaviour anymore. This commit removes the feature flags in question. (flags: webc_runner, cache, wasi, debug, emscripten, cache-blake3-pure ) Closes #3954
theduke
force-pushed
the
issue-3954-remove-old-cli-feature-flags
branch
from
795b948 to
40c409a
Compare
syrusakbary
reviewed
Jun 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CLI previously had a bunch of feature flags, which were only left in
for legacy support, but which do not change behaviour anymore.
This commit removes the feature flags in question.
(flags: webc_runner, cache, wasi, debug, emscripten, cache-blake3-pure )
Closes #3954