Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Workspace metadata #3918

Merged
merged 17 commits into from
May 30, 2023
Merged

Workspace metadata #3918

merged 17 commits into from
May 30, 2023

Conversation

Michael-F-Bryan
Copy link
Contributor

@Michael-F-Bryan Michael-F-Bryan commented May 26, 2023 •
edited
Loading

This PR...

  • Switches to using workspace metadata (@ptitSeb this means the version number for our "core" crates only need to be changed in the root /Cargo.toml file - which part of the release script will I need to update?)
  • Bumps the MSRV to 1.67 (stable is 1.69 and we usually lag by 2 versions)
  • Upgrades to the 2021 edition and fixes a bunch of resulting lints

@Michael-F-Bryan Michael-F-Bryan marked this pull request as ready for review May 26, 2023 09:12
@Michael-F-Bryan Michael-F-Bryan enabled auto-merge May 26, 2023 10:00
@Michael-F-Bryan Michael-F-Bryan merged commit 3b7af17 into master May 30, 2023
@Michael-F-Bryan Michael-F-Bryan deleted the workspace-metadata branch May 30, 2023 14:30
@Michael-F-Bryan Michael-F-Bryan mentioned this pull request Jun 8, 2023
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ptitSeb ptitSeb ptitSeb approved these changes

@syrusakbary syrusakbary syrusakbary approved these changes

@theduke theduke Awaiting requested review from theduke

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Michael-F-Bryan @syrusakbary @ptitSeb