lib/wasi: try removing base absolute path check #3914
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We merged #3867 before everyone was fully agreed that it was the right
approach. The alternate discussed is shown here (in the initial commit of this
PR), which is to remove the
!base_inode.deref().name.starts_with('/')portionof the logic.
I am opening this PR to demonstrate via the new integration test I added in
#3867 (see
tests/integration/cli/tests/snapshots/snapshot__snapshot_readdir_tree.snap) how
removing that bit of logic breaks the
path_filestat_getsyscall.