Add filesystem mappings to the resolver #3913
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Michael-F-Bryan
force-pushed
the
fs-table
branch
2 times, most recently
from
7d86544 to
559d7c9
Compare
theduke
approved these changes
Jun 6, 2023
There was a problem hiding this comment.
Appreciate the comments.
Especially
/// As a result, we'll duct-tape things together and hope for the best 🤞
This looks reasonable to me, though I haven't done an entirely thorough review.
Can we have a test to ensure that a [fs] mapping with a local dir works?
added 14 commits
June 8, 2023 23:57
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #3744 by teaching the resolver how to determine the resulting filesystem based on the
[fs]table in the manifest for each package in a dependency tree.I've also moved the
DependencyGraphstruct over to using a true graph library (petgraph) because I found myself constantly re-implementing common graph operations like dfs and toposort.