Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed all deprecated functions #3910

Merged
merged 5 commits into from
May 25, 2023
Merged

Removed all deprecated functions #3910

merged 5 commits into from
May 25, 2023

Conversation

syrusakbary
Copy link
Member

This PR fixes #3799 by removing all deprecated functions (excepts of those introduced in Wasmer 4.0)

theduke
theduke reviewed May 25, 2023
View reviewed changes
Copy link
Contributor

@theduke theduke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should also remove the functions that have been moved to NativeEngineExt.

@syrusakbary
Copy link
Member Author

This should also remove the functions that have been moved to NativeEngineExt.

Fixed

ptitSeb
ptitSeb approved these changes May 25, 2023
View reviewed changes
Copy link
Contributor

@ptitSeb ptitSeb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@ptitSeb ptitSeb enabled auto-merge (squash) May 25, 2023 11:39
@syrusakbary syrusakbary disabled auto-merge May 25, 2023 11:43
@syrusakbary syrusakbary merged commit da14770 into master May 25, 2023
@syrusakbary syrusakbary deleted the remove-deprecated branch May 25, 2023 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@theduke theduke theduke left review comments

@ptitSeb ptitSeb ptitSeb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove all deprecated functions from 3.0
3 participants
@syrusakbary @theduke @ptitSeb