Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WASIX updates after superset changes #3906

Merged
merged 8 commits into from
May 24, 2023
Merged

WASIX updates after superset changes #3906

merged 8 commits into from
May 24, 2023

Conversation

john-sharratt
Copy link
Contributor

  • allow_multiple_wasi_versions argument is removed, this is no longer a warning
  • WASIX bus syscalls are all removed
  • fixes for the WASIX filetype
  • socket types have been reordered
  • new functions added for sock_accept_v2 and thread_spawn_v2
  • added in tracing for imports
  • removed the local thread variable syscalls
  • updated the snapshot tests

@john-sharratt
WASIX updates after superset changes
3be7413 
- allow_multiple_wasi_versions argument is removed, this is no longer a warning
- WASIX bus syscalls are all removed
- fixes for the WASIX filetype
- socket types have been reordered
- new functions added for sock_accept_v2 and thread_spawn_v2
- added in tracing for imports
- removed the local thread variable syscalls
- updated the snapshot tests
@john-sharratt john-sharratt requested a review from theduke May 24, 2023 14:03
@theduke theduke mentioned this pull request May 24, 2023
Closed
theduke
theduke reviewed May 24, 2023
View reviewed changes
Copy link
Contributor

@theduke theduke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable to me.

We'll need follow-up work, like removing the is_wasix flag from WasiFs and unify behaviour.

That might also require changes in libc etc though.

@theduke theduke enabled auto-merge (rebase) May 24, 2023 17:53
@theduke theduke mentioned this pull request May 24, 2023
Closed
auto-merge was automatically disabled May 24, 2023 18:54

Rebase failed

@theduke theduke merged commit e62efef into master May 24, 2023
@theduke theduke deleted the wasix-superset branch May 24, 2023 18:56
This was referenced May 25, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@theduke theduke theduke approved these changes

@syrusakbary syrusakbary Awaiting requested review from syrusakbary

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@john-sharratt @theduke