Rework Module deserialization functions #3894
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theduke
force-pushed
the
issue-3727-rename-deserialize-fns
branch
5 times, most recently
from
863fd91 to
aa228d9
Compare
theduke
force-pushed
the
issue-3727-rename-deserialize-fns
branch
2 times, most recently
from
8333741 to
d184831
Compare
ptitSeb
reviewed
May 23, 2023
theduke
force-pushed
the
issue-3727-rename-deserialize-fns
branch
2 times, most recently
from
402e115 to
3ea5fdd
Compare
Rework the deserialize/deserialize_checked methods for module deserialization. * Make deserialize() methods use artifact validation * Make checked methods unsafe again, because loading executable memory is inherently unsafe * Rename methods that skip artifact validation to deserialize_unchecked Closes #3727
theduke
force-pushed
the
issue-3727-rename-deserialize-fns
branch
from
3ea5fdd to
bedcb17
Compare
ptitSeb
approved these changes
May 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rework the deserialize/deserialize_checked methods for module
deserialization.
Make checked methods unsafe again, because loading executable memory
Required because loading executable code into memory is inherently unsafe
Remove _checked suffix from methods that use artifact validation,
Rename methods that skip artifact validation to deserialize_unchecked
Closes #3727