Add compiler features to wai-bindgen-wasmer #3879
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Specify which compiler you want to use with a feature directly in
wai-bindgen-wasmer
.Current situation:
When you want to use
wai-bindgen-wasmer
with thesys
feature, you have to separately include wasmer to specify which compiler you want to use, like this:Why this is suboptimal:
There are several reasons:
wai-bindgen-wasmer
would not know this and would be confused by the compiler error.wai-bindgen-wasmer::wamser
or justwasmer
in your code.With the proposed change:
You just specify which compiler you want to use directly in the
wai-bindgen-wasmer
dependency:Things to consider:
Should
cranelift
be enabled by default when usingsys
? It is when using wasmer directly, but I don't think that would fit here well. Alternatively,sys
could be removed in favor ofsys-cranelift
,sys-singlepass
andsys-llvm
instead.Also, is there a changelog for the
wai-vingen-wasmer
crate, or should I put this change to the main changelog?