refactor!: Memory API Modifications (try_clone/copy, duplicate_in_store) #3874
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theduke
changed the title
theduke
force-pushed
the
issue-3810-try-clone-return
branch
2 times, most recently
from
0379991 to
0c92b90
Compare
* Change the try_clone and try_copy methods to return a Result<_, MemoryError> This is a more informative return type than the previous Option<>, and allows handling failure cases better * Remove deprecated duplicate_in_store() method Closes #3810
theduke
force-pushed
the
issue-3810-try-clone-return
branch
from
0c92b90 to
4f05785
Compare
syrusakbary
approved these changes
May 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the try_clone and try_copy methods to return a Result<_, MemoryError>
This is a more informative return type than the previous Option<>,
and allows handling failure cases better
Remove deprecated duplicate_in_store() method
Closes #3810
Partial work for #3799