Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: Upgrade clap to v4 #3854

Merged
merged 3 commits into from
May 12, 2023
Merged

deps: Upgrade clap to v4 #3854

merged 3 commits into from
May 12, 2023

Conversation

theduke
Copy link
Contributor

@theduke theduke commented May 11, 2023

Upgrade clap from 3.x to 4.2.7 in both the main CLI and the compiler
CLI.

Needed as a prep work for future CLI additions.

@theduke theduke requested a review from syrusakbary as a code owner May 11, 2023 10:47
@theduke theduke requested a review from ptitSeb May 11, 2023 10:47
@theduke
Copy link
Contributor Author

theduke commented May 11, 2023

Damn, clap has a new dependency anstream, which doesn't compile to wasi.

@theduke theduke force-pushed the deps-upgrade-clap branch 2 times, most recently from 8d1b932 to c06f481 Compare May 11, 2023 11:29
Copy link
Contributor

@ptitSeb ptitSeb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, the parse(from_os_str) attribute is no longer neeed?

@theduke
Copy link
Contributor Author

theduke commented May 11, 2023

No, PathBuf works automatically now.

@theduke theduke force-pushed the deps-upgrade-clap branch 2 times, most recently from b1d86f6 to 91a8b65 Compare May 12, 2023 06:15
@theduke theduke enabled auto-merge (rebase) May 12, 2023 06:37
@theduke theduke force-pushed the deps-upgrade-clap branch from 91a8b65 to 6e827fc Compare May 12, 2023 06:37
theduke added 3 commits May 12, 2023 10:22
Upgrade clap from 3.x to 4.2.7 in both the main CLI and the compiler
CLI.

Needed as a prep work for future CLI additions.
Feature does not work correctly on wasm due to the "anstream" dependency
not compiling
Clap 4 requires the conflicting arg name to the Rust name, instead of
the user-visible arg name.
@theduke theduke force-pushed the deps-upgrade-clap branch from 6e827fc to cfbe94c Compare May 12, 2023 08:22
@theduke theduke merged commit a5db549 into master May 12, 2023
@theduke theduke deleted the deps-upgrade-clap branch May 12, 2023 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants