Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapted the publishing script #3843

Merged
merged 1 commit into from
May 4, 2023
Merged

Adapted the publishing script #3843

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion scripts/publish.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@
"wasmer-cli": "default,cranelift",
"wasmer-wasix": "sys,wasmer/sys",
"wasmer-wasix-types": "wasmer/sys",
"wasmer-wasix-experimental-io-devices": "wasmer-wasix/sys",
"wasmer-wasix-experimental-io-devices": "wasmer-wasix/sys,wasmer/sys",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the only one with multiple features, does the code properly handle splitting?
Or is this just passed to -F or similar so it works fine?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not the only one. wasmer-cli and wasmer-wasix also have 2 features. the while features test is used as-is with no issues.

"wasmer-wast": "wasmer/sys",
"wai-bindgen-wasmer": "sys",
"wasmer-cache": "wasmer/sys",
Expand Down