Fix Missing WaiterError export + Add notify/wait to fd_mmap memory #3833
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is not a breaking change because the type is not yet public.
* WaiterError really has to be public, because it's part of the LinearMemory public interface Not making this public was an oversight * ThreadConditions is made public to allow for re-use in other crates. It is supposed to be semi-private though, and hence #[doc(hidden)].
Needed to align with upstream wait/notify introduction.
theduke
force-pushed
the
wait-notify-fixup
branch
from
f386393 to
1e8ebef
Compare
ptitSeb
approved these changes
Apr 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: WaiterError is part of the public API in the LinearMemory trait, so not making it public was an oversight.