Hook up wasi exit code to wasmer cli #383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…asmer into feature/wasi-return-exit-code
|
bors try |
bjfish
reviewed
Apr 22, 2019
syrusakbary
approved these changes
Apr 22, 2019
bjfish
reviewed
Apr 22, 2019
| abi, | ||
| if let Some(cn) = &options.command_name { | ||
| cn | ||
| let start: Func<(), ()> = instance.func("_start").map_err(|e| format!("{:?}", e))?; |
There was a problem hiding this comment.
There doesn't seem to be agreement on _start function yet (see linked wasi issue):
#362
This is a little out of scope of this PR but maybe we could only call _start if it exists.
There was a problem hiding this comment.
Yeah, I wasn't sure what to do for that. Maybe we should keep as is and make a different pr for that?
There was a problem hiding this comment.
Yeah, I think a separate PR.
bjfish
reviewed
Apr 22, 2019
| .dyn_func("main") | ||
| .map_err(|e| format!("{:?}", e))? | ||
| .call(&args) | ||
| .map_err(|e| format!("{:?}", e))?; |
There was a problem hiding this comment.
Also sort of unrelated to this PR, I hope this becomes a command:
#281 (comment)
wasmer call file.wasm function_name arg1 arg2
There was a problem hiding this comment.
This is a good idea, we should make an issue for that.
bjfish
approved these changes
Apr 23, 2019
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Apr 23, 2019
383: Hook up wasi exit code to wasmer cli r=lachlansneff a=lachlansneff Test by running: ``` > target/release/wasmer run examples/exit.wat > echo $? ``` should echo "7". Fixes (at least the exit code part) of #361. Co-authored-by: Lachlan Sneff <[email protected]>
surban
pushed a commit
to rust-wasi-web/wwrr
that referenced
this pull request
Nov 9, 2024
Bump the `wasmer` dependency to pick up wasmerio#4366
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test by running:
should echo "7".
Fixes (at least the exit code part) of #361.