Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: add docs.ts test builds #3819

Merged
merged 2 commits into from
Apr 27, 2023
Merged

ci: add docs.ts test builds #3819

merged 2 commits into from
Apr 27, 2023

Conversation

meskill
Copy link
Contributor

@meskill meskill commented Apr 24, 2023 •
edited
Loading

For only the packages with specific set of features for docs.rs building

Description

/claim #3802

@meskill meskill requested a review from syrusakbary as a code owner April 24, 2023 20:32
@meskill meskill force-pushed the ci/test-docs-rs branch 2 times, most recently from e232a0a to 6ff5386 Compare April 24, 2023 20:56
@meskill meskill mentioned this pull request Apr 24, 2023
Closed
@syrusakbary
Copy link
Member

It seems tests are failing

@meskill meskill force-pushed the ci/test-docs-rs branch 2 times, most recently from 663e436 to 8ab23f1 Compare April 25, 2023 06:42
@meskill
Copy link
Contributor Author

meskill commented Apr 25, 2023

It seems tests are failing

fixed now.

Here is the example of failed job that I reproduced by bringing back mistaken code from fix

syrusakbary
syrusakbary reviewed Apr 25, 2023
View reviewed changes
Makefile Outdated Show resolved Hide resolved
@meskill
ci: add docs.ts test builds
6ebc2e4 
For only the packages with specific set of features for docs.rs building
@meskill
Copy link
Contributor Author

meskill commented Apr 25, 2023

Some tests are failing, but I don't think it is related to my changes

@syrusakbary
Copy link
Member

By looking at the logs, it seems only "lib/compiler" and "lib/api" are being tested. Not sure why, but that needs to be fixed

@meskill
Copy link
Contributor Author

meskill commented Apr 26, 2023 •
edited
Loading

By looking at the logs, it seems only "lib/compiler" and "lib/api" are being tested. Not sure why, but that needs to be fixed

This is intentional as I wanted to test only packages with [package.metadata.docs.rs] features i.e. settings that can affect building documentation on docs.rs. That the issue was about. Also, there is already a job build-docs in makefile that will build all documentation with default set of features, although only on master.

@syrusakbary
Copy link
Member

Got it. Looks good!

@syrusakbary syrusakbary merged commit 0769e3d into wasmerio:master Apr 27, 2023
@Michael-F-Bryan Michael-F-Bryan mentioned this pull request Apr 27, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@syrusakbary syrusakbary syrusakbary approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@meskill @syrusakbary