Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wasi runner args #3805

Merged
merged 4 commits into from
Apr 21, 2023
Merged

Wasi runner args #3805

merged 4 commits into from
Apr 21, 2023

Conversation

Michael-F-Bryan
Copy link
Contributor

Turns out we were adding arguments to the WasiEnvBuilder twice when setting up WASI-based runners. I'm guessing I forgot to remove the original add_args() line when I split out populate_args().

Fixes #3789.

@Michael-F-Bryan Michael-F-Bryan requested review from ptitSeb and ayys April 21, 2023 07:21
ptitSeb
ptitSeb approved these changes Apr 21, 2023
View reviewed changes
Copy link
Contributor

@ptitSeb ptitSeb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

look good to me

@Michael-F-Bryan Michael-F-Bryan merged commit 0b44bf1 into master Apr 21, 2023
@Michael-F-Bryan Michael-F-Bryan deleted the wasi-runner-args branch April 21, 2023 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ptitSeb ptitSeb ptitSeb approved these changes

@ayys ayys Awaiting requested review from ayys

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

WASI-based runners don't pass arguments to the WebAssembly instance correctly
2 participants
@Michael-F-Bryan @ptitSeb