Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use webc's compat layer in more places #3777

Merged
merged 10 commits into from
Apr 20, 2023
Merged

Use webc's compat layer in more places #3777

merged 10 commits into from
Apr 20, 2023

Conversation

Michael-F-Bryan
Copy link
Contributor

This PR moves the wasmer_wasix::wapm module over to the webc crate's compatibility layer so we are decoupled from the version of WEBC a particular file uses.

@Michael-F-Bryan Michael-F-Bryan marked this pull request as ready for review April 18, 2023 17:50
@Michael-F-Bryan Michael-F-Bryan requested a review from theduke April 19, 2023 07:16
theduke
theduke requested changes Apr 19, 2023
View reviewed changes
lib/wasi/src/state/env.rs Outdated Show resolved Hide resolved
lib/wasi/src/state/env.rs Outdated Show resolved Hide resolved
lib/wasi/src/wapm/mod.rs Show resolved Hide resolved
john-sharratt
john-sharratt reviewed Apr 19, 2023
View reviewed changes
lib/wasi/src/state/env.rs Outdated Show resolved Hide resolved
lib/wasi/src/wapm/mod.rs Show resolved Hide resolved
syrusakbary
syrusakbary approved these changes Apr 19, 2023
View reviewed changes
Copy link
Member

@syrusakbary syrusakbary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

theduke
theduke approved these changes Apr 20, 2023
View reviewed changes
Copy link
Contributor

@theduke theduke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: we could store Arc<BinaryPackage> references on WasiEnv to improve the ownership safety. (with the module cache handing out Arc<BinaryPackage> instead of cloning.

But that can happen inn future work.

@Michael-F-Bryan Michael-F-Bryan merged commit 14ae368 into master Apr 20, 2023
@Michael-F-Bryan Michael-F-Bryan deleted the use-compat-everywhere branch April 20, 2023 14:04
@Michael-F-Bryan Michael-F-Bryan mentioned this pull request May 17, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@john-sharratt john-sharratt john-sharratt left review comments

@theduke theduke theduke approved these changes

@syrusakbary syrusakbary syrusakbary approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Michael-F-Bryan @syrusakbary @theduke @john-sharratt