Added basic support to inode in filestat_get (for #3583 and #3239) #3765
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Michael-F-Bryan
approved these changes
Apr 13, 2023
|
Is there any reason why we need to set the |
Low level fs don't all have inode. It would be nice to have low level vfs set it up, but that would require intessive change for now, so a high level change will be fine for now. |
theduke
approved these changes
Apr 13, 2023
|
@ptitSeb we should have a test for this. |
|
@theduke, I added a test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added basic support to inode in filestat_get.
the field
st_devis still 0, but thest_inois now set to theu64value of the current inodes.The effectively fixed #3583
And also fixes #3239