Fix the absolute/relative path weirdness when setting up WASI-based runner filesystems #3704
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Michael-F-Bryan
force-pushed
the
relative-vs-absolute-paths
branch
from
a438b2f to
4d6de92
Compare
syrusakbary
approved these changes
Mar 24, 2023
added 6 commits
March 24, 2023 21:40
Michael-F-Bryan
force-pushed
the
relative-vs-absolute-paths
branch
from
c6de93c to
b625531
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a bunch of hacks and workarounds so the
WasiRunnercan run Python scripts and theWcgiRunnercan serve files from the host.I've also introduced a
TraceFileSystemthat can be useful when debugging filesystem operations, and fixed the#[tracing::instrument]annotations on all our syscalls so they will actually log things like file fdescriptors (turns out#[tracing::instrument(..., fields(fd), ...)]won't actually log thefdvariable).