Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PluggableRuntime Cleanup #3692

Merged
merged 3 commits into from
Mar 21, 2023
Merged

PluggableRuntime Cleanup #3692

merged 3 commits into from
Mar 21, 2023

Conversation

theduke
Copy link
Contributor

@theduke theduke commented Mar 20, 2023

  • refactor(wasi): Rename PluggableRuntimeImplementation to PluggableRuntime
  • chore: Remove a redundant feature toggle
  • chore: Remove sys feature gates
  • Remove PluggableRuntime::default()

@theduke theduke requested a review from syrusakbary as a code owner March 20, 2023 20:28
@theduke theduke force-pushed the mandatory-virtual-taskmanager branch 2 times, most recently from 71de958 to b3e0388 Compare March 20, 2023 20:36
@theduke
Copy link
Contributor Author

theduke commented Mar 20, 2023

These are just changes that we want regardless.

I did not yet make it mandatory to specify a runtime in WasiEnvBuilder::new().

@theduke theduke force-pushed the mandatory-virtual-taskmanager branch 2 times, most recently from c663501 to ab65f0e Compare March 20, 2023 23:02
@theduke theduke requested a review from ptitSeb March 21, 2023 10:48
ptitSeb
ptitSeb approved these changes Mar 21, 2023
View reviewed changes
Copy link
Contributor

@ptitSeb ptitSeb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

theduke added 3 commits March 21, 2023 17:50
@theduke
refactor(wasi): Rename PluggableRuntimeImplementation to PluggableRun…
c003fe6 
…time

The *Implementation suffix is just pure noise.
@theduke
chore: Remove sys feature gate on WasiRuntime::engine
21fec7f 
No longer necessary due to Wasmer unification
@theduke
Remove PluggableRuntime::default()
3910a4e 
We don't want this impl anymore, because the user should be forced to
supply the virtual task manager manually so they are cognizent of the
fact they WASIX is running on an async runtime.
@theduke theduke force-pushed the mandatory-virtual-taskmanager branch from ab65f0e to 3910a4e Compare March 21, 2023 16:51
@theduke theduke enabled auto-merge (rebase) March 21, 2023 16:51
@theduke theduke merged commit 4a99b50 into master Mar 21, 2023
@theduke theduke deleted the mandatory-virtual-taskmanager branch March 21, 2023 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ptitSeb ptitSeb ptitSeb approved these changes

@syrusakbary syrusakbary Awaiting requested review from syrusakbary

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@theduke @ptitSeb