Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Master with fixes #3687

Merged
merged 24 commits into from
Mar 29, 2023
Merged

Master with fixes #3687

merged 24 commits into from
Mar 29, 2023

Conversation

syrusakbary
Copy link
Member

@syrusakbary syrusakbary commented Mar 16, 2023

This PR aims to do a bit of cleanup of Wasmer codebase:

  • Fixed sys/js features in wasmer when used with dependencies
  • Use singlepass if available in macOS M1
  • Removed unused types/functions from WASIX
  • Refactored WASIX to don't use VM internals
  • Remove dependency of Wasmer/sys from WASI
  • Improve JS API with new type implementing AsJs

@syrusakbary syrusakbary changed the title [WIP] Master with fixes Master with fixes Mar 16, 2023
# Conflicts:
#	lib/wasi/Cargo.toml
#	lib/wasi/src/runtime/mod.rs
#	lib/wasi/src/runtime/task_manager/mod.rs
#	lib/wasi/src/runtime/task_manager/tokio.rs
#	lib/wasi/src/syscalls/wasix/proc_fork.rs
#	lib/wasi/src/syscalls/wasix/thread_spawn.rs
# Conflicts:
#	lib/wasi/src/runtime/task_manager/tokio.rs
@syrusakbary
Copy link
Member Author

This PR is mainly improving WASIX to not make use of VM internals, so it can be used easily by any runtime configuration.
This is required to improve some other things such as different runtime engine support and so on, and the rest of changes are trivial.

I'll proceed to merge since all tests are already passing and this is blocking other work

# Conflicts:
#	lib/c-api/Cargo.toml
#	lib/cache/Cargo.toml
#	lib/cli/Cargo.toml
#	lib/emscripten/Cargo.toml
#	lib/wasi/Cargo.toml
This reverts commit a5500fb.

# Conflicts:
#	lib/api/src/externals/memory.rs
#	lib/wasi/src/runtime/task_manager/tokio.rs
#	lib/wasi/src/syscalls/wasix/thread_spawn.rs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant