Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes a fix to the module cache.
In the function below we see that we have three points:
when_cached
and then subtract it from the current platform time akanow
Issue:
Assuming two threads reading on same webc
Actions Series
|
| ---> 1️⃣ ----> 2️⃣ ---🔒(on cache_webc) ------------------------ 🔓 (on cache_webc and update when_cached) ------ 3️⃣ --- 🟥
| ---> 1️⃣ ----> 2️⃣ ----^--🕐 (wait for lock release) ---------^ 🔒 (on cache_webc and read updated when_cached) ----- 3️⃣ --- 🟥
|.....................................................................................................................Fails as when_cached is greater than now ^
________________________________________________________________________________________________________________________ Time
So this failure results in a value overflow in 3️⃣ and causes a crash in the tokio_runtime and thus fails the IP tests in
wasmer_deploy_testing