-
Notifications
You must be signed in to change notification settings - Fork 824
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Renamed some crates and changed their version to 0.1.0 #3683
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you not rename the directories on purpose?
The repo would become very inconsistent and confusing without aligning them with the crate names.
But this will be a very annoying change though for all open PRs, so if we do this we please need to merge #3653 first, because that's a large PR, and rebasing this PR on top of that one will be much easier than the other way around.
Alternative is to first merge without renaming the directories, try to get all large PRs in and then do the dir rename as a second PR.
Yes, that was on purpose. I propose the crates that have ben rename to How closed is the #3653 to be merged? |
I think @john-sharratt is still fixing some stuff. If we want to get this beta out quickly we can merge without renaming the directories and do that as a followup - but I do think we should get that PR in first either way because the conflicts would be annoying regardless.
I actually see it almost the other way around - it's more important for |
I'm fine with renaming all the foler. It's just that it will be an anoying PR to handle for sure. |
I've done a deeper review of the naming, and I don't think we should use I'd go with:
|
Renamed: