Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(wasi): Add CapabilityThreading with max thread count #3664

Merged
merged 1 commit into from
Mar 8, 2023
Merged

feat(wasi): Add CapabilityThreading with max thread count #3664

merged 1 commit into from
Mar 8, 2023

Conversation

theduke
Copy link
Contributor

@theduke theduke commented Mar 8, 2023

Extends the wasi Capabilities type with a setting for threading that
configures the maximum thread count.

@theduke
feat(wasi): Add CapabilityThreading with max thread count
bce105c 
Extends the wasi Capabilities type with a setting for threading that
configures the maximum thread count.
Michael-F-Bryan
Michael-F-Bryan approved these changes Mar 8, 2023
View reviewed changes
Copy link
Contributor

@Michael-F-Bryan Michael-F-Bryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like we're just propagating max_threads through the config to the WasiControlPlane. Makes sense 👍

@theduke theduke enabled auto-merge (rebase) March 8, 2023 09:54
@theduke theduke merged commit 041c211 into master Mar 8, 2023
@theduke theduke deleted the capability-threading branch March 8, 2023 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Michael-F-Bryan Michael-F-Bryan Michael-F-Bryan approved these changes

@ptitSeb ptitSeb ptitSeb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@theduke @ptitSeb @Michael-F-Bryan