-
Notifications
You must be signed in to change notification settings - Fork 824
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dash fixes and pthreads #3663
Dash fixes and pthreads #3663
Conversation
…emembered beyond its exit
Note the snapshot tests won't work until I regenerate them all - which I'll do now but be aware they are not backwards compatible |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly looks good to me, apart from some smaller requests and one larger issue (Errno).
Snapshot tests are updated but there is a strange cranelift error that is not understood
|
Just a small restructuring that moves the capabilities submodule from state into the root lib. Done because it is now exported in full rather than just partially from state::, and because it is a more generic module that will probably be moved out to a separate crate soon.
…into dash-fixes-and-pthreads
…cy issue when tests run in parallel
…into dash-fixes-and-pthreads
5a54a0b
to
32c0b3c
Compare
-- Fixed some linting issues on the "--" argument fix of the wasmer command - Fixed the unit tests for dash and bash subprocesses - Fixed the order of the flushing of files so that processes are notified of exit only after the open file handles are flushed - Added a step that explictily flushes the stdout and stderr on cleanup of an exited process
32c0b3c
to
8312c2e
Compare
b9c5d21
to
0b8d2b1
Compare
…ing of stdout and stderr
This merge brings in support for pthreads using the WASI threads spec and fixes a number of issues with dash WASIX