Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed building with with just the sys feature #3659

Merged
merged 1 commit into from
Mar 7, 2023
Merged

Fixed building with with just the sys feature #3659

merged 1 commit into from
Mar 7, 2023

Conversation

ptitSeb
Copy link
Contributor

@ptitSeb ptitSeb commented Mar 7, 2023

Fix the build with

cargo build --no-default-features --features=sys --manifest-path=lib/api/Cargo.toml

(used in CI)

@ptitSeb ptitSeb requested a review from syrusakbary as a code owner March 7, 2023 14:14
@ptitSeb ptitSeb requested a review from theduke March 7, 2023 14:14
Michael-F-Bryan
Michael-F-Bryan approved these changes Mar 7, 2023
View reviewed changes
Copy link
Contributor

@Michael-F-Bryan Michael-F-Bryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I verified that this builds on my local machine, so it should be good to merge as soon as CI is green 👍

@ptitSeb ptitSeb merged commit 627a726 into master Mar 7, 2023
@ptitSeb ptitSeb deleted the fix_min_build branch March 7, 2023 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Michael-F-Bryan Michael-F-Bryan Michael-F-Bryan approved these changes

@syrusakbary syrusakbary Awaiting requested review from syrusakbary

@theduke theduke Awaiting requested review from theduke

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ptitSeb @Michael-F-Bryan