deps: Remove tempdir dependency #3646
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
syrusakbary
approved these changes
Mar 6, 2023
We already depend on `tempfile`, which also provides temp dir functionality. This gets rid of a cargo-deny error due to a race condition in remove_dir_all, which is a dependency of the removed "tempdir" crate. Also bumps the minimum tempfile version in Cargo.toml files to be consistent.
theduke
force-pushed
the
upgrade-tempfile-dep
branch
from
5c40975 to
3ffcc82
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We already depend on
tempfile, which also provides temp dirfunctionality, so this removes a redundant additional dependency.
This also gets rid of a cargo-deny error due to a race condition in
remove_dir_all, which is a dependency of the removed "tempdir" crate.
Bumps the minimum tempfile version in Cargo.toml files to be
consistent.