fix(wasi): Memory leak due to cyclical WasiControlPlane references #3643
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ptitSeb
reviewed
Mar 6, 2023
ptitSeb
approved these changes
Mar 6, 2023
Fixed by WasiProcess just storing a Weak<> handle to the control plane. Note: This could/should also be changed so that the WasiProcess does not have a handle to the control plane at all, but that requires some slightly bigger refactoring that also changes or removes the SignalHandlerAbi Closes #3642
theduke
force-pushed
the
wasi-fix-cyclical-leak
branch
from
5ff0733 to
984b9a3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed by WasiProcess just storing a Weak<> handle to the control plane.
Note: This could/should also be changed so that the WasiProcess does not
have a handle to the control plane at all, but that requires some
slightly bigger refactoring that also changes or removes the SignalHandlerAbi
Closes #3642