wasi: Remove vbus leftovers and improve task joining #3627
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* A new TaskStatus is introduced that specifies the current state of a task (usually a process or thread) * Status tracking is refactored to use tokio::sync::watch instead of a homegrown solution which combined channels and mutexes * The task status now not just tracks an exit code, but also the ocurred error This helps consumers of the task status to know that and error ocurred, and which one, which helps debugging / logging and potential recovery * Remove the unused VBUS crate leftover types and traits Almost all gone, except for the VirtualBusError * Move SignalHandlerAbi types to os::signal
theduke
force-pushed
the
wasi-spawn-handle
branch
from
ebc5d78 to
c98ccaf
Compare
|
Per @john-sharratt s request I ensured that |
syrusakbary
approved these changes
Feb 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(usually a process or thread)
homegrown solution which combined channels and mutexes
This helps consumers of the task status to know that and error
ocurred, and which one, which helps debugging / logging and potential
recovery
Almost all gone, except for the VirtualBusError
Closes #3625