add basic coredump generation #3626
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
WOW. The PR ended being way simpler than I was imagining. I'll review it on Monday with @ptitSeb |
syrusakbary
reviewed
Feb 24, 2023
xtuc
force-pushed
the
sven/basic-coredump
branch
2 times, most recently
from
38f573f to
bc17c8f
Compare
syrusakbary
reviewed
Feb 24, 2023
|
Hey @xtuc, could you also add a documentation file on how to use wasm-coredump with wasmer? (end to end) Thanks! |
|
@syrusakbary yes sure. This is what I wrote for wasmtime: https://github.com/bytecodealliance/wasmtime/blob/db931d7a93208738b8106e8d8c1a4afc8efaca6d/docs/examples-coredump.md. Where's the best place to write such a documentation for wasmer? |
Probably having that markdown doc inside the |
xtuc
force-pushed
the
sven/basic-coredump
branch
from
bc17c8f to
ca04122
Compare
This change adds a basic coredump generation after a WebAssembly trap was entered. The coredump includes rudimentary stack / process debugging information. A new CLI argument is added to enable coredump generation: ``` wasmer --coredump-on-trap=/path/to/coredump/file module.wasm ``` See docs/en/examples-coredump.md. Refs wasmerio#3578
xtuc
force-pushed
the
sven/basic-coredump
branch
from
ca04122 to
ed0951f
Compare
|
@syrusakbary added some docs. |
syrusakbary
approved these changes
Feb 28, 2023
|
Looks great, merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds a basic coredump generation after a WebAssembly trap was entered. The coredump includes rudimentary stack / process debugging information.
A new CLI argument is added to enable coredump generation:
Refs #3578