Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added conveniance function FunctionEnvMut::data_and_store_mut #3612

Merged
merged 5 commits into from
Feb 28, 2023
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -241,6 +241,11 @@ name = "imported-function-env"
path = "examples/imports_function_env.rs"
required-features = ["cranelift"]

[[example]]
name = "imported-function-env-global"
path = "examples/imports_function_env_global.rs"
required-features = ["cranelift"]

[[example]]
name = "hello-world"
path = "examples/hello_world.rs"
Expand Down
2 changes: 2 additions & 0 deletions examples/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -368,6 +368,8 @@ example.
[exported-memory]: ./exports_memory.rs
[imported-global]: ./imports_global.rs
[imported-function]: ./imports_function.rs
[imported-function-env]: ./imports_function_env.rs
[imported-function-env-global]: ./imports_function_env_global.rs
[instance]: ./instance.rs
[wasi]: ./wasi.rs
[wasi-pipes]: ./wasi_pipes.rs
Expand Down
156 changes: 156 additions & 0 deletions examples/imports_function_env_global.rs
Original file line number Diff line number Diff line change
@@ -0,0 +1,156 @@
//! A Wasm module can import entities, like functions, memories,
//! globals and tables.
//!
//! In this example, we'll create a system for getting and adjusting a counter value. However, host
//! functions are not limited to storing data outside of Wasm, they're normal host functions and
//! can do anything that the host can do.
//! we will also demonstrate how a Function can also get globals from within a wasm call
//!
//! 1. There will be a `get_counter` function that will return an i32 of
//! the current global counter, The function will also increment a global value
//! 2. There will be an `add_to_counter` function will add the passed
//! i32 value to the counter, and return an i32 of the current
//! global counter.
//!
//! You can run the example directly by executing in Wasmer root:
//!
//! ```shell
//! cargo run --example imported-function-env-global --release --features "cranelift"
//! ```
//!
//! Ready?

use std::sync::{Arc, Mutex};
use wasmer::{
imports, wat2wasm, Function, FunctionEnv, FunctionEnvMut, Global, Instance, Module, Store,
TypedFunction, Value,
};
use wasmer_compiler_cranelift::Cranelift;

fn main() -> Result<(), Box<dyn std::error::Error>> {
// Let's declare the Wasm module with the text representation.
let wasm_bytes = wat2wasm(
br#"
(module
(global $g_counter (import "env" "g_counter") (mut i32))
(func $get_counter (import "env" "get_counter") (result i32))
(func $add_to_counter (import "env" "add_to_counter") (param i32) (result i32))

(type $increment_t (func (param i32) (result i32)))
(func $increment_f (type $increment_t) (param $x i32) (result i32)
(block
(loop
(call $add_to_counter (i32.const 1))
(set_local $x (i32.sub (get_local $x) (i32.const 1)))
(br_if 1 (i32.eq (get_local $x) (i32.const 0)))
(br 0)))
call $get_counter)
(export "increment_counter_loop" (func $increment_f)))
"#,
)?;

// Create a Store.
// Note that we don't need to specify the engine/compiler if we want to use
// the default provided by Wasmer.
// You can use `Store::default()` for that.
let mut store = Store::new(Cranelift::default());

println!("Compiling module...");
// Let's compile the Wasm module.
let module = Module::new(&store, wasm_bytes)?;

// Create the global
let g_counter = Global::new_mut(&mut store, Value::I32(5));

// We create some shared data here, `Arc` is required because we may
// move our WebAssembly instance to another thread to run it. Mutex
// lets us get shared mutabilty which is fine because we know we won't
// run host calls concurrently. If concurrency is a possibilty, we'd have
// to use a `Mutex`.
let shared_counter: Arc<Mutex<i32>> = Arc::new(Mutex::new(0));

// Once we have our counter we'll wrap it inside en `Env` which we'll pass
// to our imported functionsvia the FunctionEnv.
//
// This struct may have been anything. The only constraint is it must be
// possible to know the size of the `Env` at compile time (i.e it has to
// implement the `Sized` trait).
// The Env is then accessed using `data()` or `data_mut()` method.
#[derive(Clone)]
struct Env {
counter: Arc<Mutex<i32>>,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this do need to be a mutex?

Copy link
Member

@syrusakbary syrusakbary Feb 23, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just read the comment

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But I'm not sure if I agree with it, we can discuss in a call

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's based on the import_function_env example, it's really mostly copy/paste. But we can have a call about the examples for sure.

g_counter: Global,
}

// Create the functions
fn get_counter(env: FunctionEnvMut<Env>) -> i32 {
*env.data().counter.lock().unwrap()
}
fn add_to_counter(mut env: FunctionEnvMut<Env>, add: i32) -> i32 {
let (data, mut storemut) = env.data_and_store_mut();
let mut counter_ref = data.counter.lock().unwrap();

let global_count = data.g_counter.get(&mut storemut).unwrap_i32();
data.g_counter
.set(&mut storemut, Value::I32(global_count + add));

*counter_ref += add;
*counter_ref
}

let env = FunctionEnv::new(
&mut store,
Env {
counter: shared_counter.clone(),
g_counter: g_counter.clone(),
},
);

// Create an import object.
let import_object = imports! {
"env" => {
"get_counter" => Function::new_typed_with_env(&mut store, &env, get_counter),
"add_to_counter" => Function::new_typed_with_env(&mut store, &env, add_to_counter),
"g_counter" => g_counter.clone(),
}
};

println!("Instantiating module...");
// Let's instantiate the Wasm module.
let instance = Instance::new(&mut store, &module, &import_object)?;

// Here we go.
//
// The Wasm module exports a function called `increment_counter_loop`. Let's get it.
let increment_counter_loop: TypedFunction<i32, i32> = instance
.exports
.get_function("increment_counter_loop")?
.typed(&mut store)?;

let counter_value: i32 = *shared_counter.lock().unwrap();
println!("Initial ounter value: {:?}", counter_value);

println!("Calling `increment_counter_loop` function...");
// Let's call the `increment_counter_loop` exported function.
//
// It will loop five times thus incrementing our counter five times.
let result = increment_counter_loop.call(&mut store, 5)?;

let counter_value: i32 = *shared_counter.lock().unwrap();
println!("New counter value (host): {:?}", counter_value);
assert_eq!(counter_value, 5);

println!("New counter value (guest): {:?}", result);
assert_eq!(result, 5);

let global_counter = g_counter.get(&mut store);
println!("New global counter value: {:?}", global_counter);
assert_eq!(global_counter.unwrap_i32(), 10);

Ok(())
}

#[test]
fn test_imported_function_env() -> Result<(), Box<dyn std::error::Error>> {
main()
}
11 changes: 11 additions & 0 deletions lib/api/src/js/function_env.rs
Original file line number Diff line number Diff line change
Expand Up @@ -124,6 +124,17 @@ impl<T: Send + 'static> FunctionEnvMut<'_, T> {
func_env: self.func_env.clone(),
}
}

/// Borrows a new mutable reference of both the attached Store and host state
pub fn data_and_store_mut(&mut self) -> (&mut T, StoreMut) {
let data = self.func_env.as_mut(&mut self.store_mut) as *mut T;
// telling the borrow check to close his eyes here
// this is still relatively safe to do as func_env are
// stored in a specific vec of Store, separate from the other objects
// and not really directly accessible with the StoreMut
let data = unsafe { &mut *data };
(data, self.store_mut.as_store_mut())
}
}

impl<T> AsStoreRef for FunctionEnvMut<'_, T> {
Expand Down
11 changes: 11 additions & 0 deletions lib/api/src/sys/function_env.rs
Original file line number Diff line number Diff line change
Expand Up @@ -117,6 +117,17 @@ impl<T: Send + 'static> FunctionEnvMut<'_, T> {
func_env: self.func_env.clone(),
}
}

/// Borrows a new mutable reference of both the attached Store and host state
pub fn data_and_store_mut(&mut self) -> (&mut T, StoreMut) {
let data = self.func_env.as_mut(&mut self.store_mut) as *mut T;
// telling the borrow check to close his eyes here
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After reviewing the API, I don't see any other (public) way to get access to the FunctionEnv in StoreInner, so this should be safe from a public API standpoint.

Of course internally we could still violate this.

A thing I thought about yesterday : we could put the FunctionEnvs behind a RefCell to make this a bit more ssafer, but that would come with some overhead.

But otherwise I think this is a not ideal, but acceptable use of unsafe.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, agreed

// this is still relatively safe to do as func_env are
// stored in a specific vec of Store, separate from the other objects
// and not really directly accessible with the StoreMut
let data = unsafe { &mut *data };
(data, self.store_mut.as_store_mut())
}
Comment on lines +120 to +130
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add it on the js version as well and add a #[universal_test] verifying the desired behavior? (that way, we test that it also works in js)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is on js (in the 2nd commit).
I'll find something for a test.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh I missed the js impl. Let's just have an universal test

}

impl<T> AsStoreRef for FunctionEnvMut<'_, T> {
Expand Down