Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move the wcgi-runner into Wasmer #3599

Merged
merged 26 commits into from
Mar 6, 2023
Merged

Move the wcgi-runner into Wasmer #3599

merged 26 commits into from
Mar 6, 2023

Conversation

Michael-F-Bryan
Copy link
Contributor

@Michael-F-Bryan Michael-F-Bryan commented Feb 22, 2023 •
edited
Loading

As discussed previously, we're moving the wcgi-runner crate into the wasmerio/wasmer repo so it can be integrated into the wasmer CLI.

Fixes #3600.

@Michael-F-Bryan Michael-F-Bryan added this to the v3.2 milestone Feb 22, 2023
Base automatically changed from wasix to master February 23, 2023 19:57
theduke
theduke reviewed Feb 24, 2023
View reviewed changes
lib/wcgi-runner/examples/wcgi-runner.rs Outdated Show resolved Hide resolved
lib/wcgi-runner/src/annotations.rs Outdated Show resolved Hide resolved
lib/wcgi-runner/src/builder.rs Outdated Show resolved Hide resolved
lib/wcgi-runner/src/builder.rs Outdated Show resolved Hide resolved
lib/wcgi-runner/src/builder.rs Outdated Show resolved Hide resolved
lib/wcgi-runner/src/builder.rs Outdated Show resolved Hide resolved
lib/wcgi-runner/src/context.rs Outdated Show resolved Hide resolved
lib/wcgi-runner/tests/integration.rs Outdated Show resolved Hide resolved
lib/wcgi-runner/tests/integration.rs Outdated Show resolved Hide resolved
lib/wcgi-runner/src/runner.rs Outdated Show resolved Hide resolved
@Michael-F-Bryan Michael-F-Bryan mentioned this pull request Feb 24, 2023
Closed
@Michael-F-Bryan Michael-F-Bryan marked this pull request as ready for review February 28, 2023 18:37
syrusakbary
syrusakbary reviewed Feb 28, 2023
View reviewed changes
lib/cli/Cargo.toml Outdated Show resolved Hide resolved
@syrusakbary
Copy link
Member

The PR looks hacikly good... let's merge once tests pass

theduke
theduke reviewed Mar 2, 2023
View reviewed changes
Copy link
Contributor

@theduke theduke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I'm reading the code correctly there is no way to run a local .wasm file with the runner, right?

How are you supposed to develop locally then?
For me that's a baseline requirement.

@Michael-F-Bryan Michael-F-Bryan force-pushed the wcgi-runner branch 2 times, most recently from b07ff36 to 563090e Compare March 3, 2023 14:38
@Michael-F-Bryan Michael-F-Bryan mentioned this pull request Mar 6, 2023
Closed
@Michael-F-Bryan Michael-F-Bryan merged commit 4a1f779 into master Mar 6, 2023
@Michael-F-Bryan Michael-F-Bryan deleted the wcgi-runner branch March 6, 2023 16:45
@Michael-F-Bryan Michael-F-Bryan mentioned this pull request Apr 20, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@theduke theduke theduke left review comments

@syrusakbary syrusakbary syrusakbary approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.2
Development

Successfully merging this pull request may close these issues.

Move the wcgi_runner crate to the Wasmer repository
3 participants
@Michael-F-Bryan @syrusakbary @theduke