Wasix multithreading fix #3598
Merged
Wasix multithreading fix #3598
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a thread corruption issue causes when real threads spawned a thread multiple times. This occured because the thread context was being reused from previously exited threads. Also there was a bug in the futex_wait callback where it was not correctly returning the woken event
Because it is required.
theduke
force-pushed
the
wasix-threading-fix
branch
from
56ec64e to
927a924
Compare
theduke
approved these changes
Feb 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a thread corruption issue causes when real threads spawned a thread
multiple times. This occurred because the thread context was being reused
from previously exited threads.
Also there was a bug in the
futex_waitcallback where it was not correctlyreturning the woken event