Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: experimental io #3591

Merged
merged 4 commits into from
Feb 28, 2023
Merged

fix: experimental io #3591

merged 4 commits into from
Feb 28, 2023

Conversation

kotborealis
Copy link
Contributor

@kotborealis kotborealis commented Feb 18, 2023

Description

Multiple fixes to experimental IO devices:

  • enabled experimental-io-devices feature in makefile;
  • bumped minifb crate to the latest version;
  • updated experimental-io-devices crate to actually compile and work - fs calls were out of date;
  • fixed subtle bug in framebuffer resize function, where both width and height were set to width;
  • reworked input handling: before this PR, pressing and holding key was emitting KEY_PRESS and KEY_RELEASE on the same frame; now, it functions as expected: on key press KEY_PRESS event is written to the buffer, on key release KEY_RELEASE is written.

Tested on my small attempt to run Doom on wasmer (https://github.com/kotborealis/doomer).

p.s. Maybe I should consider splitting this into multiple PR's?

Makefile Outdated Show resolved Hide resolved
Copy link
Member

@syrusakbary syrusakbary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once the small change is addressed we should be good to merge

@kotborealis kotborealis force-pushed the master branch 3 times, most recently from 93f3999 to e566a44 Compare February 22, 2023 17:39
@syrusakbary
Copy link
Member

Once conflicts are resolved, we should be good to merge!

@syrusakbary syrusakbary merged commit e3c8041 into wasmerio:master Feb 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants