Make memoryView lifetime linked to StoreRef instead of Memory #3580
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ptitSeb
changed the title
ptitSeb
changed the title
|
I'd like to rereview/merge this after we merge the unification PR: #3556 |
syrusakbary
approved these changes
Mar 15, 2023
|
Merged manually as tests worked (other than a http flake) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Sys (not on JS), make MemoryView lifetime linked to the StoreRef instead of the Memory.
For #3516 and #3567
This change in the Lifetime makes the examples in both tickets impossible to build.