Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/compile not in memory #3573

Merged
merged 8 commits into from
Feb 6, 2023
Merged

Fix/compile not in memory #3573

merged 8 commits into from
Feb 6, 2023

Conversation

ptitSeb
Copy link
Contributor

@ptitSeb ptitSeb commented Feb 3, 2023 •
edited
Loading

When compiling an artifact, don't load compiled result in memory if the the compilation target is not compatible with the host.

This will also help with #3508 because runtime unwind information will not be constructed when Cross-compiling.

Note that they are some small API-breaking changes here:

  • A new InstantiationError::DifferentArchOS
  • Artifact::from_parts(...) now takes a 3rd parameter (&Target of the parts)

@ptitSeb ptitSeb requested a review from syrusakbary as a code owner February 3, 2023 17:48
@ptitSeb ptitSeb merged commit 1387363 into master Feb 6, 2023
@ptitSeb ptitSeb deleted the fix/compile-not-in-memory branch February 6, 2023 09:28
@ptitSeb ptitSeb mentioned this pull request Feb 6, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@syrusakbary syrusakbary syrusakbary approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ptitSeb @syrusakbary