Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove setting memory for WASI compatibility #3547

Merged
merged 1 commit into from
Jan 26, 2023
Merged

Conversation

syrusakbary
Copy link
Member

I found some dangling code that was no longer needed (since it's not present either in the sys counterpart).

Needs review @theduke @john-sharratt

Copy link
Contributor

@theduke theduke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We still very much require "memory" to be exported, but that is actually the case anyway for most of the common build systems targeting WASM, so this should be fine!

If anything breaks we can always re-add the logic in -wasi.

@syrusakbary syrusakbary merged commit 6ecc800 into master Jan 26, 2023
@syrusakbary syrusakbary deleted the wasix-remove-memory branch January 26, 2023 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants