Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump inkwell to 0.1.0 #3537

Merged
merged 6 commits into from
Jan 31, 2023
Merged

bump inkwell to 0.1.0 #3537

merged 6 commits into from
Jan 31, 2023

Conversation

hamidrezakp
Copy link
Contributor

@hamidrezakp hamidrezakp commented Jan 26, 2023

Bumped inkwell dependency to 0.1.0

Also i would like to know if you have any plans to use llvm-sys with latest version or not, i can try to refactor the code.

Copy link
Member

@syrusakbary syrusakbary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, great work!

@hamidrezakp
Copy link
Contributor Author

Looks good to me, great work!

Thank you!

@hamidrezakp
Copy link
Contributor Author

Is there anything needed from my side to make this PR merged?

@ptitSeb
Copy link
Contributor

ptitSeb commented Jan 30, 2023

Is there anything needed from my side to make this PR merged?

Nothing on your side. We have some issues with github actions not triggering here.

@syrusakbary
Copy link
Member

After some days we have no idea on why tests are not being triggered.
To keep things going, I'll merge and see if tests pass in master. If they don't, we can revert the merge afterwards

@syrusakbary
Copy link
Member

@hamidrezakp we had to revert this PR in #3563 because a bug in inkwell. Once that's resolved we should be good to merge it again

@hamidrezakp
Copy link
Contributor Author

Oh, that's okay, sorry for taking your time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants