Use JS VM store instead of artificially replicate it #3534
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ptitSeb
reviewed
Jan 26, 2023
| functions => VMFunction, | ||
| tables => VMTable, | ||
| // Note: we store the globals in order to be able to access them later via | ||
| // `StoreObjects::iter_globals`. | ||
| globals => VMGlobal, |
There was a problem hiding this comment.
but VMGlobal are not handled as a StoreObject anymore. Isn't there a risk of unsynchronisation here?
There was a problem hiding this comment.
Isn't there a risk of unsynchronisation here?
No. The only risk is the fact that the globals are stored in the Store as a side effect. But they are stored and work nonetheless.
But I think we should probably remove that after merging WASIX
ptitSeb
reviewed
Jan 26, 2023
ptitSeb
approved these changes
Jan 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use JS VM store instead of artificially replicate it.
Right now all the JS VMs use a single store (v8 isolates, for example) per process. We were replicating the store unnecessarily in Rust, when we can just leverage that store.
This PR should bring some relative speed ups on the outer interface of Wasmer (for example, when doing function calls) or getting exports of an instance