Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add unit test for verifying that caching works when running packages twice #3512

Merged
merged 23 commits into from
Jan 26, 2023
Merged

Add unit test for verifying that caching works when running packages twice #3512

merged 23 commits into from
Jan 26, 2023

Conversation

fschutt
Copy link
Contributor

@fschutt fschutt commented Jan 20, 2023

Fixes #3510.

@fschutt fschutt marked this pull request as draft January 20, 2023 15:03
@fschutt fschutt changed the title Fix caching issue in wasmer run Add unit test for verifying that caching works when running packages twice Jan 20, 2023
@fschutt fschutt marked this pull request as ready for review January 20, 2023 16:29
@fschutt fschutt requested a review from syrusakbary as a code owner January 20, 2023 16:44
@fschutt
Copy link
Contributor Author

fschutt commented Jan 23, 2023

@syrusakbary It seems that this test will always fail on Windows, because we use : in file names / directories for vendored packages. We need to agree / sync on a new syntax for vendoring packages before pushing this PR. This test however only fails on vendored packages, not on normal ones, so it's safe to release the 3.2.0-alpha before merging this PR.

@fschutt fschutt enabled auto-merge January 26, 2023 14:43
@fschutt fschutt merged commit e8a604b into master Jan 26, 2023
@fschutt fschutt deleted the fix-caching-issue-customlambda branch January 26, 2023 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@syrusakbary syrusakbary syrusakbary approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

wasmer run corrupts package on the second run on the hackathon branch
2 participants
@fschutt @syrusakbary