Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incremented CURRENT_VERSION, so all cache will be invalidate and be rebuilt with the 3.2 version #3511

Merged
merged 4 commits into from
Jan 20, 2023

Conversation

ptitSeb
Copy link
Contributor

@ptitSeb ptitSeb commented Jan 20, 2023

This will force all old Cache to be purged and regenerated.
This should also fix #3509 , #3510 and #3470

@fschutt fschutt force-pushed the fix_inc-CURRENT_VERSION branch from 4b366ef to 97ae242 Compare January 20, 2023 15:43
@fschutt
Copy link
Contributor

fschutt commented Jan 20, 2023

The issue is that create-exe links the objects using the libwasmer.a pulled from GitHub (which expects the old METADATA_HEADER_VERSION). That's why the tests fail because wasmer-cli generates objects with version 2, but object_metadata_deserialize from libwasmer.a still expects version 1.

We need to disable tests, release the alpha and the re-enable the tests.

@syrusakbary syrusakbary merged commit bf7031a into master Jan 20, 2023
@syrusakbary syrusakbary deleted the fix_inc-CURRENT_VERSION branch January 20, 2023 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

wasmer run segfaults on current master branch
4 participants