Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed some memory leak issue with InstanceHandle #3493

Merged
merged 6 commits into from
Jan 25, 2023
Merged

Fixed some memory leak issue with InstanceHandle #3493

merged 6 commits into from
Jan 25, 2023

Conversation

ptitSeb
Copy link
Contributor

@ptitSeb ptitSeb commented Jan 18, 2023 •
edited
Loading

This is help with #3485
This memory leak is also tracked there: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=55183

@ptitSeb ptitSeb requested a review from syrusakbary as a code owner January 18, 2023 11:49
syrusakbary
syrusakbary requested changes Jan 25, 2023
View reviewed changes
Copy link
Member

@syrusakbary syrusakbary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rename: InstanceHandle to VMInstance and write_instance to into_vminstance

@theduke
Copy link
Contributor

theduke commented Jan 25, 2023

I guess you are aware, but that rename is a breaking change and would require a major version bump for the vm crate.

@ptitSeb
Copy link
Contributor Author

ptitSeb commented Jan 25, 2023 •
edited
Loading

I guess you are aware, but that rename is a breaking change and would require a major version bump for the vm crate.

I think InstanceHandle is only used Internaly. So we should be safe.

@theduke
Copy link
Contributor

theduke commented Jan 25, 2023

It's in the public API of -vm, so at least that create would need a bump.

@theduke
Copy link
Contributor

theduke commented Jan 25, 2023

It's also in the public api, because of Artifact::instantiate().

@ptitSeb
Copy link
Contributor Author

ptitSeb commented Jan 25, 2023

This also fixes https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=55183 when tested localy

@ptitSeb ptitSeb requested a review from syrusakbary January 25, 2023 13:43
syrusakbary
syrusakbary approved these changes Jan 25, 2023
View reviewed changes
Copy link
Member

@syrusakbary syrusakbary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@ptitSeb ptitSeb merged commit a5a4f06 into master Jan 25, 2023
@ptitSeb ptitSeb deleted the fix_instancehandle_memoryleak branch January 25, 2023 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@syrusakbary syrusakbary syrusakbary approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ptitSeb @theduke @syrusakbary