Fix wasm publish validation #3473
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Michael-F-Bryan
approved these changes
Jan 11, 2023
There was a problem hiding this comment.
Looks good to me 👍
After talking with @syrusakbary this evening, I agree with the idea of enabling all WebAssembly features while validating.
One option is to get the flags from wasmer::Features::default() instead of hard-coding them, but that would enforce validation using the current Wasmer defaults. We are actually trying to validate that each atom would be runnable by the end runner, though, and there is no way to know which features a runner would enable or disable (something that's essentially impossible to know).
Given that, I agree with being "optimistic" and allowing all WebAssembly features when validating packages before publishing - it's more of a sanity check, anyway.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up from this PR: wasmerio/wapm-cli#305