Use GNU/Linux frame registration code for FreeBSD too #3439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MalloryA
force-pushed
the
freebsd-libunwind
branch
from
0d9c717 to
cca6978
Compare
This change prevents a long hang when a program exits. FreeBSD's `__deregister_frame` and `__register_frame` implementations are ported from GCC, which is why we should be using the same frame registration code for FreeBSD and GNU/Linux. Link: https://github.com/freebsd/freebsd-src/blob/release/13.1.0/contrib/llvm-project/libunwind/src/UnwindLevel1-gcc-ext.c#L241-L299 Fixes: wasmerio#3373
MalloryA
force-pushed
the
freebsd-libunwind
branch
from
cca6978 to
5648e50
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change prevents a long hang when a program exits.
FreeBSD's
__deregister_frameand__register_frameimplementations are ported from GCC, which is why we should be using the same frame registration code for FreeBSD and GNU/Linux.Link: https://github.com/freebsd/freebsd-src/blob/release/13.1.0/contrib/llvm-project/libunwind/src/UnwindLevel1-gcc-ext.c#L241-L299
Fixes: #3373
Review