Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement support for multiple commands in one native executable #3430

Merged
merged 141 commits into from
Jan 5, 2023

Conversation

fschutt
Copy link
Contributor

@fschutt fschutt commented Dec 16, 2022

Fixes #3425.
Fixes #3374.
Fixes #3436.

TODO

Currently we aren't running integration tests on Windows, so this led to problems when debugging, since

I can only re-enable integration tests after #3353 is merged, since that PR will change the CI structure massively (doesn't make sense to re-enable before).

I temporarily enabled linking towasmer-headless.a and got the binary size of the exe from 24 MB to 9 MB stripped, but this is causing issues on linux-aarch64 because we currently build libwasmer-headless.a with the wrong flags.

  • Refactor create-obj and create-exe
  • Fix create-exe to use caching with --precompiled-atom syntax
  • Fix --precompiled-atom caching not working with linker (esp. --object-format serialized is causing linker issues)
  • Re-enable integration tests on Windows after Speed up CI #3353 is merged

@fschutt fschutt requested a review from syrusakbary as a code owner December 16, 2022 13:38
@fschutt fschutt self-assigned this Dec 16, 2022
@fschutt fschutt marked this pull request as draft December 16, 2022 13:38
@fschutt
Copy link
Contributor Author

fschutt commented Jan 5, 2023

Okay @syrusakbary it seems that the object files generated by Artifact::generate_object are corrupted both on master and on multi-command-exe. I’ll hand this issue over to @ptitSeb since he has more context on this.

@fschutt fschutt enabled auto-merge January 5, 2023 18:04
@syrusakbary syrusakbary disabled auto-merge January 5, 2023 20:30
@syrusakbary syrusakbary merged commit 494e2ea into master Jan 5, 2023
@syrusakbary syrusakbary deleted the multi-command-exe branch January 5, 2023 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants