-
Notifications
You must be signed in to change notification settings - Fork 824
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement wasmer config #3428
Implement wasmer config #3428
Conversation
I would prefer a simpler: But yeah, the switch from That's just personnal taste, nothing blocking. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wasmer config --pkg-config
and others (--include-dir
) should NOT live in wasmer config get
in any case. wasmer config get {KEY}
are for settings that can be configured by the user via the counterpart wasmer config set {KEY} {VALUE}
.
We need to preserve old behavior for the previously existing config flags
Now supports --prefix and [get | set] subcommands
This reverts commit d311e27.
@syrusakbary the default config now looks like this: wax_cooldown = 0
telemetry_enabled = false
update_notifications_enabled = false
[registry]
active_registry = "https://registry.wapm.dev/graphql"
tokens = []
[proxy]
wasmer/lib/registry/src/config.rs Line 206 in 58ee174
... will fail if we do non-backwards compatible breaking changes to the |
Probably not, but we should assure that when renaming the old |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, relying on @syrusakbary sign off yesterday.
Fixes #3383.