New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WASIX Preparation #3426

Merged

theduke merged 65 commits into master from wasix-core-changes

Jan 16, 2023

Contributor

theduke commented Dec 15, 2022 •

edited

Loading

This commit extracts changes to core libraries made in the WASIX branch.

It is not reasonable to extract the partial commit history, so this is
just a batch commit.

The history will make a bit more sense again if we decide to merge the
WASIX branch with full commit history.

theduke requested a review from syrusakbary as a code owner

December 15, 2022 11:16

theduke requested review from fschutt and ptitSeb

December 15, 2022 11:16

theduke force-pushed the wasix-core-changes branch from 6ef298d to acedd30 Compare

December 15, 2022 12:45

Contributor Author

theduke commented Dec 15, 2022 •

edited

Loading

The Linux runtime test fails with:

test test_wasmer_create_exe_pirita_works ... compiling to target x86_64-unknown-linux-gnu
packaging /package to .tar.gz: /tmp/.tmpxSTqhk/link.tar.gz
packaging done
tmp tar gz path: /tmp/.tmpxSTqhk/link.tar.gz - exists: true
running: "/home/runner/work/wasmer/wasmer/tests/integration/cli/../../../target/x86_64-unknown-linux-gnu/release/wasmer" "create-exe" "/tmp/.tmp2IYt78/python.wasmer" "--tarball" "/tmp/.tmpxSTqhk/link.tar.gz" "--target" "x86_64-unknown-linux-gnu" "-o" "/tmp/.tmp2IYt78/python"
compilation ok!
Error: python_exe_output_path /tmp/.tmp2IYt78/python does not exist

Is that something unrelated to this PR, or is this something I need to investigate?

theduke force-pushed the wasix-core-changes branch from 736742d to 06801d6 Compare

December 15, 2022 22:18

syrusakbary reviewed

View reviewed changes

lib/api/src/js/export.rs Outdated Show resolved Hide resolved

syrusakbary reviewed

View reviewed changes

lib/api/src/js/externals/memory.rs Outdated Show resolved Hide resolved

syrusakbary reviewed

View reviewed changes

lib/api/src/sys/tunables.rs Outdated Show resolved Hide resolved

syrusakbary reviewed

View reviewed changes

lib/vm/src/memory.rs Outdated Show resolved Hide resolved

syrusakbary reviewed

View reviewed changes

lib/vm/src/memory.rs Outdated Show resolved Hide resolved

syrusakbary reviewed

View reviewed changes

lib/vm/src/memory.rs Outdated Show resolved Hide resolved

syrusakbary reviewed

View reviewed changes

lib/vm/src/memory.rs Outdated Show resolved Hide resolved

syrusakbary reviewed

View reviewed changes

lib/vm/src/memory.rs Outdated Show resolved Hide resolved

syrusakbary reviewed

View reviewed changes

lib/vm/src/memory.rs Outdated Show resolved Hide resolved

syrusakbary reviewed

View reviewed changes

lib/vm/src/memory.rs Outdated Show resolved Hide resolved

syrusakbary reviewed

View reviewed changes

lib/vm/src/memory.rs Outdated Show resolved Hide resolved

syrusakbary reviewed

View reviewed changes

lib/api/src/js/module.rs Outdated Show resolved Hide resolved

syrusakbary reviewed

View reviewed changes

lib/api/src/js/module.rs Outdated Show resolved Hide resolved

syrusakbary reviewed

View reviewed changes

lib/api/src/js/module.rs Outdated Show resolved Hide resolved

syrusakbary reviewed

View reviewed changes

lib/api/src/js/module.rs Outdated Show resolved Hide resolved

syrusakbary reviewed

View reviewed changes

lib/api/src/js/module.rs Outdated Show resolved Hide resolved

syrusakbary reviewed

View reviewed changes

lib/api/src/js/native.rs Show resolved Hide resolved

syrusakbary reviewed

View reviewed changes

lib/api/src/js/store.rs Outdated Show resolved Hide resolved

theduke force-pushed the wasix-core-changes branch 2 times, most recently from 3725976 to b03f58e Compare

December 15, 2022 23:37

theduke commented

View reviewed changes

lib/api/src/sys/exports.rs Outdated Show resolved Hide resolved

lib/compiler-cranelift/Cargo.toml Outdated Show resolved Hide resolved

lib/types/src/memory.rs Show resolved Hide resolved

lib/api/src/js/export.rs Outdated Show resolved Hide resolved

lib/api/src/js/module.rs Outdated Show resolved Hide resolved

lib/api/src/js/module.rs Show resolved Hide resolved

syrusakbary reviewed

View reviewed changes

lib/vm/src/mmap.rs Outdated Show resolved Hide resolved

syrusakbary reviewed

View reviewed changes

lib/vm/src/mmap.rs Outdated Show resolved Hide resolved

syrusakbary reviewed

View reviewed changes

lib/types/src/store.rs Outdated Show resolved Hide resolved

syrusakbary reviewed

View reviewed changes

lib/api/src/js/instance.rs Outdated Show resolved Hide resolved

syrusakbary reviewed

View reviewed changes

lib/api/src/js/module.rs Show resolved Hide resolved

syrusakbary reviewed

View reviewed changes

lib/api/src/js/module.rs Show resolved Hide resolved

syrusakbary reviewed

View reviewed changes

lib/vm/src/function_env.rs Show resolved Hide resolved

syrusakbary reviewed

View reviewed changes

lib/wasi/src/runners/mod.rs Show resolved Hide resolved

theduke and others added 3 commits

January 2, 2023 12:43


          ci: Use 1.64 toolchain

d45f58d

Missed this during the last merge.


          Split js::Instance::from_module_and_instance externs/memory tests in …

bf2f855

…a separate function


          Rename js::Instance::check_memory to ensure_memory_export

9f7822d

ptitSeb approved these changes

View reviewed changes

ptitSeb added 2 commits

January 3, 2023 14:07


          Added TODO on asynctify code, linking to ticket #3451

332ad85


          Merge branch 'master' into wasix-core-changes

6a42c2b

syrusakbary reviewed

View reviewed changes

lib/compiler/src/compiler.rs Outdated Show resolved Hide resolved

ptitSeb added 4 commits

January 4, 2023 18:02


          [JS] Rmoved js-serializable-module feature from wasm-types-polyfill

a050376


          Missed some sources to add a TODO mark about asynctify

212f836


          Removed default Compiler::name() implementation

9fbc7f4


          Fixed linter

5b5d032

syrusakbary reviewed

View reviewed changes

lib/api/src/js/native.rs Outdated Show resolved Hide resolved

ptitSeb added 4 commits

January 5, 2023 09:24


          Changed TODO mark about asyncify

8d7190b


          Added one more TODO, about the imported/exported memory hack on js

b126849


          Fixed linter

60d1fcf


          Merge branch 'master' into wasix-core-changes

26b43fe

syrusakbary approved these changes

View reviewed changes

Member

syrusakbary left a comment

Looks good.

ptitSeb and others added 5 commits

January 16, 2023 09:39


          Merge branch 'master' into wasix-core-changes

87eb05d


          Merge branch 'master' into wasix-core-changes

36048fa


          Fixed error message in test-integration-cli-ci

e73f195


          Merge branch 'master' into wasix-core-changes

4c5b773


          chore; Add some explanatory comments on allow(unused_unsafe) annotations

e9edb7e

theduke enabled auto-merge

January 16, 2023 23:25

theduke merged commit 0785137 into master

theduke deleted the wasix-core-changes branch

January 16, 2023 23:42

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet